-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Switch to Storybook from Styleguidist #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@stefhatcher @hayes Finished converting all stories. Can pull the storybook locally and test it. |
6c0fa15
to
1f6dd82
Compare
@alecklandgraf @hayes @stefhatcher This is good to go. Went ahead and wrote my own props addon. |
stefhatcher
reviewed
Apr 16, 2019
stefhatcher
reviewed
Apr 16, 2019
stefhatcher
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @stefhatcher @hayes @alecklandgraf
Description
Migrates from Styleguidist to Storybook. This is a proof of concept, let me know your thoughts.
Open questions:
story.tsx
files live?Motivation and Context
Storybook v5 is really good and offers the following features:
However, things it does poorly compared to Styleguidist.
Ugly/useless prop tables (inferred from TS types).(Implemented a custom addon)Testing
TBD
Screenshots
Checklist