[TECH-471] VotingRounds #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
av-alexistoledo
approved these changes
Dec 5, 2022
av-alexander
reviewed
Dec 5, 2022
| @@ -510,6 +513,18 @@ export class AVClient implements IAVClient { | |||
| return ballotConfigs[voterSession.content.voterGroup] | |||
| } | |||
|
|
|||
| public getVoterContestConfigs(): ContestConfig[] { | |||
There was a problem hiding this comment.
Where is this method used?
There was a problem hiding this comment.
It is not used in JS-client, but I asked @av-mads yesterday, and he told me that it is supposed to be used by calling it from outside (instances of AVclient I'd guess).
There was a problem hiding this comment.
It's used by liminal I think. May also be used elsewhere
av-alexander
approved these changes
Dec 6, 2022
av-alexistoledo
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.