Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote encoding - part 2 (Type changes) #173

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Vote encoding - part 2 (Type changes) #173

merged 2 commits into from
Jun 2, 2022

Conversation

av-michael
Copy link
Contributor

This PR should be reviewed after part 1 has been merged to main.

This PR introduces:

  • Option type can now have an optional writeIn property
  • MarkingType changes structure to allow setting encoding options
  • Tests are fixed to allow the marking type changes (integration tests are left alone for now)

@av-michael
Changing structure of MarkingType
e98979d 
This commit will break integration tests with DBB
@av-michael av-michael requested a review from av-mads June 2, 2022 11:11
@av-michael av-michael merged commit d5fa31e into main Jun 2, 2022
@av-michael av-michael deleted the type-changes branch June 3, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@av-mads av-mads av-mads approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@av-michael @av-mads