Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no compare ttl on DNSRecord #218

Merged
merged 2 commits into from
Dec 29, 2024
Merged

no compare ttl on DNSRecord #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b911cd
no compare ttl on DNSRecord
mosquito Dec 29, 2024
d5f4177
mypy fixes
mosquito Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aiomisc/service/dns/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class DNSRecord:
type: RecordType
data: RD
cls: DNSClass = field(default=DNSClass.IN)
ttl: int = field(default=3600)
ttl: int = field(default=3600, compare=False)

def rr(self, query_type: int) -> dnslib.RR:
return dnslib.RR(
Expand Down
4 changes: 2 additions & 2 deletions aiomisc/service/raven.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class AioHttpTransportBase(
def __init__(
self, parsed_url: Optional[str] = None, *, verify_ssl: bool = True,
timeout: TimeoutType = defaults.TIMEOUT, keepalive: bool = True,
family: int = socket.AF_INET,
family: socket.AddressFamily = socket.AddressFamily.AF_INET,
):
self._keepalive = keepalive
self._family = family
Expand All @@ -92,7 +92,7 @@ def keepalive(self) -> bool:
return self._keepalive

@property
def family(self) -> int:
def family(self) -> socket.AddressFamily:
return self._family

def _client_session_factory(self) -> aiohttp.ClientSession:
Expand Down
Loading
Loading