Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set shutdown timeout to AppRunner instead of site #215

Merged
merged 3 commits into from
Jul 19, 2024
Merged

set shutdown timeout to AppRunner instead of site #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ffc5a0
set shutdown timeout to AppRunner instead of site
mosquito Jul 19, 2024
b1108f7
bump version
mosquito Jul 19, 2024
d862edd
rerun flaky tests
mosquito Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions aiomisc/service/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,12 @@ async def create_site(self) -> SockSite:
if getattr(self, "runner", None) is None:
raise RuntimeError("runner already created")

return SockSite(
self.runner, self.socket,
shutdown_timeout=self.shutdown_timeout,
)
return SockSite(self.runner, self.socket)

async def make_runner(self, application: Application) -> AppRunner:
return AppRunner(
application,
shutdown_timeout=self.shutdown_timeout,
**self.runner_kwargs,
)

Expand Down Expand Up @@ -129,7 +127,6 @@ async def create_site(self) -> SockSite:

return SockSite(
self.runner, self.socket,
shutdown_timeout=self.shutdown_timeout,
ssl_context=await self.loop.run_in_executor(
None, self.__ssl_options.create_context,
),
Expand Down
4 changes: 2 additions & 2 deletions aiomisc/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
# BY: poem-plugins "git" plugin
# NEVER EDIT THIS FILE MANUALLY

version_info = (17, 3, 0)
__version__ = "17.3.0"
version_info = (17, 5, 25)
__version__ = "17.5.25"
Loading
Loading