fix: Return coroutines instead of awaitables from functions. #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callable[..., Awaitable[T]]
is not a coroutine function, in fact it should beCallable[..., Coroutine[Any, Any, T]]
.If we have an interface like this:
Then for such an implementation, mypy will return an error:
We can use workaround like this:
But in this case
fetch
is not a coroutine function. We will have problems usingunittest.mock.MagicMock
: