Skip to content

Commit

Permalink
set shutdown timeout to AppRunner instead of site (#215)
Browse files Browse the repository at this point in the history
* set shutdown timeout to AppRunner instead of site
* rerun flaky tests
  • Loading branch information
mosquito authored Jul 19, 2024
1 parent c03dd1e commit 426fab4
Show file tree
Hide file tree
Showing 6 changed files with 338 additions and 307 deletions.
7 changes: 2 additions & 5 deletions aiomisc/service/aiohttp.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,12 @@ async def create_site(self) -> SockSite:
if getattr(self, "runner", None) is None:
raise RuntimeError("runner already created")

return SockSite(
self.runner, self.socket,
shutdown_timeout=self.shutdown_timeout,
)
return SockSite(self.runner, self.socket)

async def make_runner(self, application: Application) -> AppRunner:
return AppRunner(
application,
shutdown_timeout=self.shutdown_timeout,
**self.runner_kwargs,
)

Expand Down Expand Up @@ -129,7 +127,6 @@ async def create_site(self) -> SockSite:

return SockSite(
self.runner, self.socket,
shutdown_timeout=self.shutdown_timeout,
ssl_context=await self.loop.run_in_executor(
None, self.__ssl_options.create_context,
),
Expand Down
4 changes: 2 additions & 2 deletions aiomisc/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
# BY: poem-plugins "git" plugin
# NEVER EDIT THIS FILE MANUALLY

version_info = (17, 3, 0)
__version__ = "17.3.0"
version_info = (17, 5, 25)
__version__ = "17.5.25"
Loading

0 comments on commit 426fab4

Please sign in to comment.