Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12-3.13 and drop EOL 3.7 #372

Closed
wants to merge 6 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 29, 2023

What do these changes do?

The Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/

Also drop EOL Python 3.7.

Are there changes in behavior for the user?

No.

Related issue number

n/a

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a489744) to head (3ffe14d).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          116       113    -3     
  Branches        19        18    -1     
=========================================
- Hits           116       113    -3     
Flag Coverage Δ
unit 99.11% <100.00%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugovk hugovk changed the title Add support for Python 3.12 and drop EOL 3.7 Add support for Python 3.12-3.13 and drop EOL 3.7 Aug 5, 2024
@hugovk
Copy link
Contributor Author

hugovk commented Aug 5, 2024

Updated to add support for the Python 3.13 release candidate! 🚀

The Release Manager has issued a call to action:

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.13 compatibilities during this phase, and where necessary publish Python 3.13 wheels on PyPI to be ready for the final release of 3.13.0. Any binary wheels built against Python 3.13.0rc1 will work with future versions of Python 3.13. As always, report any issues to the Python bug tracker.

Also update Twine to fix the CI.

PS I usually close PRs when they're one year old, this is now 11 months old. Please let me know if you need more time or there's something else to do here. Thanks!

@Hedda
Copy link

Hedda commented Aug 28, 2024

@webknjaz Any updates on this? Please also see this issue about droping Python 3.8 support:

@hugovk
Copy link
Contributor Author

hugovk commented Sep 3, 2024

Closing this year old PR, but happy to re-open if there's interest.

@hugovk hugovk closed this Sep 3, 2024
@Hedda
Copy link

Hedda commented Sep 3, 2024

Closing this year old PR, but happy to re-open if there's interest.

There is interest but someone with commit permissions/rights has to review and merge if acceptable to them, or create a fork? 😕

@Dreamsorcerer @asvetlov @webknjaz @hugovk

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Sep 3, 2024

I've unsubscribed from the repo as I think we'll just archive this project soon, as the code has been upstreamed to asyncio.timeout() and I see little reason to continue it's development here.

Once Python 3.10 is no longer supported, we'll probably kill it officially, until then it's basically hanging around in case of security issues etc. that could need fixing. We've already dropped it in all our other projects, which you can do too using the same approach:
https://github.com/aio-libs/aiohttp/blob/5c0b8e4a7897f48063f684ac16e7dd18f6218274/aiohttp/helpers.py#L59-L62
https://github.com/aio-libs/aiohttp/blob/master/setup.cfg#L53

@Dreamsorcerer
Copy link
Member

Have updated the README to make this clear and provide those migration instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants