Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5948/bcb74cb0 backport][3.8] Feat: Add compression strategy #6127

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 24, 2021

This is a backport of PR #5948 as merged into master (bcb74cb).

What do these changes do?

Add compression strategy parameter to enable_compression method.

Are there changes in behavior for the user?

The added parameter allows users to have control over the compression.

Related issue number

#5909

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Co-authored-by: Anes Abismail <anesabismail@gmail.com>
(cherry picked from commit bcb74cb)
@patchback patchback bot requested a review from asvetlov as a code owner October 24, 2021 10:20
@patchback patchback bot mentioned this pull request Oct 24, 2021
5 tasks
@asvetlov asvetlov merged commit ba89cb2 into 3.8 Oct 24, 2021
@asvetlov asvetlov deleted the patchback/backports/3.8/bcb74cb00e1ba454dbcf25b27833deff23c2cbd9/pr-5948 branch October 24, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants