Added quote_cookie option to CookieJar
#4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapping of cookies containing special characters.
JonasKs
commented
Jul 28, 2020
This comment has been minimized.
This comment has been minimized.
|
#4408 seems to be the reason for tests to fail. |
webknjaz
reviewed
Oct 12, 2020
webknjaz
reviewed
Oct 12, 2020
…ting before variable use.
webknjaz
reviewed
Oct 13, 2020
webknjaz
reviewed
Oct 13, 2020
webknjaz
reviewed
Oct 13, 2020
webknjaz
reviewed
Oct 13, 2020
webknjaz
reviewed
Oct 13, 2020
webknjaz
reviewed
Oct 13, 2020
By @webknjaz Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
|
Linting fails in tests. I'll fix ASAP. |
|
Lint fails do not seem to be about this code, the same errors happens all PRs to this repo (even the dependabot ones). |
💔 Backport was not successfulThe PR was attempted backported to the following branches:
|
asvetlov
pushed a commit
that referenced
this pull request
Oct 15, 2020
|
@asvetlov , backport didn't work. Anything you'd like me to do? |
|
Ah, looking back I can see you fixed it. Thanks! |
|
Yes. |
|
No worries, that's understandable. Have a nice weekend! |
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Added
quote_cookieoption toCookieJar, a way to skip quotation wrapping of cookies containing special characters.Are there changes in behavior for the user?
No.
Related issue number
#2571
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.