Add tests for parsing chunked data split before or in the final CRLF (#4630) #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Mar 22, 2020
webknjaz
requested changes
Mar 22, 2020
2418ed6 to
674631b
Compare
This comment has been minimized.
This comment has been minimized.
webknjaz
reviewed
Mar 24, 2020
Per webknjaz's suggestion Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
approved these changes
Mar 25, 2020
rhdxmr
pushed a commit
to rhdxmr/aiohttp
that referenced
this pull request
Jul 1, 2020
PR aio-libs#4651 by @JustAnotherArchivist This change adds tests that demonstrate the failures described in aio-libs#4630. They are marked as xfail so that they don't affect the CI status. Once the issue is fixed, they'll reported as XPASS and pytest will fail, which would be a signal that it's time to remove the xfail markers keeping the contents of the tests to prevent regressions. (ref: https://pganssle-talks.github.io/xfail-lightning) Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
PR #4651 by @JustAnotherArchivist This change adds tests that demonstrate the failures described in #4630. They are marked as xfail so that they don't affect the CI status. Once the issue is fixed, they'll reported as XPASS and pytest will fail, which would be a signal that it's time to remove the xfail markers keeping the contents of the tests to prevent regressions. (ref: https://pganssle-talks.github.io/xfail-lightning) Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This adds four tests for issue #4630.
Are there changes in behavior for the user?
Not for users, but for developers: three of the tests are currently failing (see that issue for details).
Related issue number
#4630
Checklist
CONTRIBUTORS.txtCHANGESfolder