Fix code example in docs #4313
Merged
Fix code example in docs #4313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an typo in an example. The example referenced a non-existent function.
Codecov Report
@@ Coverage Diff @@
## master #4313 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 43 43
Lines 8862 8862
Branches 1389 1389
=======================================
Hits 8645 8645
Misses 93 93
Partials 124 124Continue to review full report at Codecov.
|
The `MultipartWriter.write` function was not being awaited hence the post function would get called before data is written to the buffer.
asvetlov
approved these changes
Nov 1, 2019
|
thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Nov 1, 2019
(cherry picked from commit 419c33c) Co-authored-by: Victor Otieno <vickz84259@gmail.com>
asvetlov
added a commit
that referenced
this pull request
Nov 1, 2019
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix a typo in an example on the page about Multipart . The example referenced a non-existent function. After fixing the typo the code still didn't run as intended. This fixes that too.
Are there changes in behavior for the user?
A working example.
Related issue number
#4312
#4314
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.