Use version: ~> 1.0, remove conditions: v1 #4162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version requirement `= 0` advertised in early development stages was an unfortunate choice, as this is going to be the opt-out once the new build config validation feature will be rolled out further. Please use `~> 1.0` instead. The conditions version `v1` is now the default, so this key can be removed.
asvetlov
approved these changes
Oct 9, 2019
asvetlov
pushed a commit
that referenced
this pull request
Oct 9, 2019
The version requirement `= 0` advertised in early development stages was an unfortunate choice, as this is going to be the opt-out once the new build config validation feature will be rolled out further. Please use `~> 1.0` instead. The conditions version `v1` is now the default, so this key can be removed. (cherry picked from commit f104e75) Co-authored-by: Sven Fuchs <me@svenfuchs.com>
asvetlov
added a commit
that referenced
this pull request
Oct 9, 2019
The version requirement `= 0` advertised in early development stages was an unfortunate choice, as this is going to be the opt-out once the new build config validation feature will be rolled out further. Please use `~> 1.0` instead. The conditions version `v1` is now the default, so this key can be removed. (cherry picked from commit f104e75) Co-authored-by: Sven Fuchs <me@svenfuchs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version requirement
= 0advertised in early development stages was an unfortunate choice, as this is going to be the opt-out once the new build config validation feature will be rolled out further. Please use~> 1.0instead.The conditions version
v1is now the default, so this key can be removed.