Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix normalize_path_middleware behavior for patch without slash (3669) #3670

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix normalize_path_middleware behavior for patch without slash (3669) #3670

merged 1 commit into from
Mar 27, 2019

Conversation

bigbag
Copy link

@bigbag bigbag commented Mar 27, 2019 •
edited
Loading

Fix for issue #3669

@bigbag bigbag requested a review from asvetlov as a code owner March 27, 2019 11:56
kxepal
kxepal requested changes Mar 27, 2019
View reviewed changes
Copy link
Member

@kxepal kxepal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, but could you, please, also add the test made by @vir-mir as a separate case? That one clearly demonstrates the issue and linked with real case.

@codecov-io
Copy link

codecov-io commented Mar 27, 2019 •
edited
Loading

Codecov Report

Merging #3670 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3670   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          43       43           
  Lines        8559     8559           
  Branches     1377     1377           
=======================================
  Hits         8378     8378           
  Misses         75       75           
  Partials      106      106
Impacted Files Coverage Δ
aiohttp/web_middlewares.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf371e...b3b86a5. Read the comment docs.

@bigbag
Copy link
Author

bigbag commented Mar 27, 2019

LGFM, but could you, please, also add the test made by @vir-mir as a separate case? That one clearly demonstrates the issue and linked with real case.

I did it in 0292b96

kxepal
kxepal approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@kxepal kxepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vir-mir
vir-mir approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@vir-mir vir-mir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kxepal kxepal merged commit 8260eda into aio-libs:master Mar 27, 2019
@kxepal
Copy link
Member

kxepal commented Mar 27, 2019

Thanks! 🍺

@lock lock bot added the outdated label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kxepal kxepal kxepal approved these changes

@vir-mir vir-mir vir-mir approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigbag @codecov-io @kxepal @vir-mir