Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify StreamWriter ctor #2958

Merged
merged 2 commits into from
Apr 26, 2018
Merged

Simplify StreamWriter ctor #2958

merged 2 commits into from
Apr 26, 2018

Conversation

asvetlov
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #2958 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2958      +/-   ##
=========================================
+ Coverage      98%     98%   +<.01%     
=========================================
  Files          40      40              
  Lines        7583    7584       +1     
  Branches     1324    1324              
=========================================
+ Hits         7432    7433       +1     
  Misses         48      48              
  Partials      103     103
Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.35% <ø> (ø) ⬆️
aiohttp/web_fileresponse.py 98.01% <ø> (ø) ⬆️
aiohttp/http_writer.py 100% <100%> (ø) ⬆️
aiohttp/web_protocol.py 91.86% <100%> (ø) ⬆️
aiohttp/test_utils.py 98.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1601d...3f6cb4c. Read the comment docs.

@asvetlov asvetlov merged commit c8483a0 into master Apr 26, 2018
@asvetlov asvetlov deleted the simplify-stream-writer branch April 26, 2018 11:04
thehesiod pushed a commit to thehesiod-forks/aiohttp that referenced this pull request Apr 26, 2018
* Simplify StreamWriter ctor

* Add changenote
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants