-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement test_client can accept instance object. #1083
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4dd7e03
Improvement test_client that can accept instance object.
ppiyakk2 6c98da4
Increase code test coverage.
ppiyakk2 317d78c
Change parameter from lambda to object instance.
ppiyakk2 88809d8
Add new testcase about testing test_client can accept object instance…
ppiyakk2 5ec49d5
Add negative test case -- passing to test_client application with wr…
ppiyakk2 bc03bee
Fix bug in test case
ppiyakk2 8c4688b
Check where args and kwargs are empty or not.
ppiyakk2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ def test_myplugin(testdir): | |
testdir.makepyfile("""\ | ||
import asyncio | ||
import pytest | ||
from unittest import mock | ||
|
||
from aiohttp import web | ||
|
||
pytest_plugins = 'aiohttp.pytest_plugin' | ||
|
@@ -59,6 +61,13 @@ def test_hello_fails(test_client): | |
assert 'Hello, wield' in text | ||
|
||
|
||
@asyncio.coroutine | ||
def test_hello_from_app_fails(test_client): | ||
with pytest.raises(AssertionError): | ||
fake_loop = mock.Mock() | ||
test_client(web.Application(loop=fake_loop)) | ||
|
||
|
||
@asyncio.coroutine | ||
def test_noop(): | ||
pass | ||
|
@@ -122,4 +131,4 @@ def make_app(loop): | |
|
||
""") | ||
result = testdir.runpytest('-p', 'no:sugar') | ||
result.assert_outcomes(passed=8, failed=1) | ||
result.assert_outcomes(passed=8, failed=2) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But why is it failing? If it fails it means that assertion is not raised. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yield from test_client(...)
-- that's why this test failsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh my god !! thanks !!!