Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10004/a334eef7 backport][3.11] Avoid building skip_headers in ClientSession._request if it will be thrown away #10006

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 20, 2024

This is a backport of PR #10004 as merged into master (a334eef).

There is a very good chance that we will build skip_headers and than throw it away as this option is not commonly passed.

Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #10006 will not alter performance

Comparing patchback/backports/3.11/a334eef76c198746b8f02e9a8a89f083a918f076/pr-10004 (138379a) with 3.11 (b235e76)

Summary

✅ 43 untouched benchmarks

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@d030c05). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11   #10006   +/-   ##
=======================================
  Coverage        ?   98.02%           
=======================================
  Files           ?      122           
  Lines           ?    36903           
  Branches        ?     4441           
=======================================
  Hits            ?    36176           
  Misses          ?      544           
  Partials        ?      183           
Flag Coverage Δ
CI-GHA 97.92% <100.00%> (?)
OS-Linux 97.62% <100.00%> (?)
OS-Windows 94.52% <ø> (?)
OS-macOS 96.73% <100.00%> (?)
Py-3.10.11 96.59% <100.00%> (?)
Py-3.10.15 97.18% <100.00%> (?)
Py-3.11.10 97.25% <100.00%> (?)
Py-3.11.9 96.66% <100.00%> (?)
Py-3.12.7 97.69% <100.00%> (?)
Py-3.13.0 97.64% <100.00%> (?)
Py-3.9.13 96.52% <100.00%> (?)
Py-3.9.20 97.10% <100.00%> (?)
Py-pypy7.3.16 96.66% <100.00%> (?)
VM-macos 96.73% <100.00%> (?)
VM-ubuntu 97.62% <100.00%> (?)
VM-windows 94.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 20, 2024 21:48
@bdraco bdraco merged commit 496f649 into 3.11 Nov 20, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/a334eef76c198746b8f02e9a8a89f083a918f076/pr-10004 branch November 20, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant