-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ws_connect doesn't follow proxy from environment #4648
Comments
Feel free to send a PR with tests bundled. |
mmasztalerczuk
added a commit
to mmasztalerczuk/aiohttp
that referenced
this issue
Mar 24, 2020
mmasztalerczuk
added a commit
to mmasztalerczuk/aiohttp
that referenced
this issue
Mar 24, 2020
mmasztalerczuk
added a commit
to mmasztalerczuk/aiohttp
that referenced
this issue
Mar 24, 2020
5 tasks
icamposrivera
pushed a commit
to icamposrivera/aiohttp
that referenced
this issue
Oct 21, 2021
PR aio-libs#4661 Resolves aio-libs#4648 Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
webknjaz
pushed a commit
to webknjaz/aiohttp
that referenced
this issue
Oct 31, 2021
PR aio-libs#4661 Resolves aio-libs#4648 Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> (cherry picked from commit 50753ea)
5 tasks
webknjaz
pushed a commit
to webknjaz/aiohttp
that referenced
this issue
Oct 31, 2021
PR aio-libs#4661 Resolves aio-libs#4648 Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> (cherry picked from commit 50753ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Describe the bug
I have set both http_proxy and https_proxy, with trust_env=True when create ClientSession,
everything is ok when get or post with this session, but for the ws_connect, It doesn't run with proxy.
💡 To Reproduce
background: I cann't visit wss://stream.binance.com:9443/ws under my network but it's ok with proxy
and it block forever (with a tcp handshake timeout exception)
💡 Expected behavior
just connect with proxy
📋 Logs/tracebacks
📋 Your version of the Python
📋 Your version of the aiohttp/yarl/multidict distributions
📋 Additional context
aiohttp/aiohttp/client.py
Line 426 in bb7a4ea
scheme of websocket is ws or wss, url.scheme will always be http or https and ignore any other proxy here
aiohttp/aiohttp/helpers.py
Line 232 in bb7a4ea
but it's ok for ws/wss to use http proxy
The text was updated successfully, but these errors were encountered: