Fix CI: update isort and flake8 for pre-commit and format files #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1037 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 1474 1472 -2
Branches 25 25
=========================================
- Hits 1474 1472 -2 ☔ View full report in Codecov by Sentry. |
…e.py cause it does not see extra dependency
bdraco
reviewed
Nov 27, 2024
bdraco
reviewed
Nov 27, 2024
|
Thanks! This looks good once the two small nits above are addressed. |
|
Sure, updated |
bdraco
approved these changes
Nov 27, 2024
Comment on lines
+17
to
+18
| # I900: flake8-requirements doesn't see aioredis in the requirements file cause it is extra dependency | ||
| aiohttp_session/redis_storage.py:I900 |
There was a problem hiding this comment.
I suspect it should be added to the requirements file for our testing. Though aioredis is archived, so we should also migrate to redis/valkey now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
pre-commit runAre there changes in behavior for the user?
Should not be any changes for the user
Related issue number
Checklist