Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Virtualize the run params list in the Run page #2182

Merged
merged 13 commits into from
Sep 23, 2022

Conversation

roubkar
Copy link
Contributor

@roubkar roubkar commented Sep 19, 2022

  • Implemented custom DictVisualizer which has built-in support for virtualization to replace react-json-view
  • Added a helper function to visualize data type
  • Added a helper function to color values based on their type

@roubkar roubkar self-assigned this Sep 19, 2022
@roubkar
Copy link
Contributor Author

roubkar commented Sep 19, 2022

Resolves #1994

@roubkar roubkar requested review from arsengit and VkoHov September 19, 2022 18:16
@roubkar roubkar changed the title [fix] Optimize rendering performance for large dicts [fix] Virtualize the run params list in the Run page Sep 20, 2022
@roubkar roubkar requested a review from VkoHov September 23, 2022 09:23
Copy link
Contributor

@VkoHov VkoHov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@roubkar roubkar merged commit 851775d into release/3.13.x Sep 23, 2022
@roubkar roubkar deleted the fix/large-dicts-visualization branch September 23, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants