Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Replace the spinner loader with a lighter one #2178

Merged
merged 4 commits into from
Sep 22, 2022
Merged

[feat] Replace the spinner loader with a lighter one #2178

merged 4 commits into from
Sep 22, 2022

Conversation

VkoHov
Copy link
Contributor

@VkoHov VkoHov commented Sep 18, 2022

The new Spinner is implemented using only the HTML and CSS which is lighter than the previous one.

@VkoHov VkoHov requested review from roubkar and arsengit September 18, 2022 17:09
@VkoHov VkoHov self-assigned this Sep 18, 2022
@VkoHov
Copy link
Contributor Author

VkoHov commented Sep 18, 2022

Resolves #2177

@VkoHov VkoHov requested review from KaroMourad and removed request for roubkar September 18, 2022 17:11
KaroMourad
KaroMourad approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@KaroMourad KaroMourad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VkoHov VkoHov merged commit feea6f0 into main Sep 22, 2022
@VkoHov VkoHov deleted the feature/replace-the-spinner-loader-with-a-lighter-one branch September 22, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsengit arsengit arsengit approved these changes

@KaroMourad KaroMourad KaroMourad approved these changes

Assignees

@VkoHov VkoHov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VkoHov @arsengit @KaroMourad