Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix regression line rendering issue on scatterplot exported image #2157

Merged
merged 2 commits into from
Sep 9, 2022
Merged

[fix] Fix regression line rendering issue on scatterplot exported image #2157

merged 2 commits into from
Sep 9, 2022

Conversation

KaroMourad
Copy link
Contributor

  • add styles directly on the SVG path as attributes

Additional small style fixes

  • fix the x-axis alignment popover overflowing issue
  • fix the depth slider shifting issue

@KaroMourad KaroMourad requested a review from arsengit September 8, 2022 14:44
@KaroMourad KaroMourad self-assigned this Sep 8, 2022
@KaroMourad KaroMourad changed the title [fix] Regression line rendering issue on scatterplot exported image [fix] Fix regression line rendering issue on scatterplot exported image Sep 8, 2022
@KaroMourad
Copy link
Contributor Author

Resolves #2155

@KaroMourad KaroMourad marked this pull request as ready for review September 8, 2022 14:46
rubenaprikyan
rubenaprikyan approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@rubenaprikyan rubenaprikyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@KaroMourad KaroMourad merged commit dc6d44d into release/3.13.x Sep 9, 2022
@KaroMourad KaroMourad deleted the fix/trendline-rendering-issue-on-scatterplot-exported-image branch September 9, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenaprikyan rubenaprikyan rubenaprikyan approved these changes

@arsengit arsengit arsengit approved these changes

Assignees

@KaroMourad KaroMourad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaroMourad @rubenaprikyan @arsengit