Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Revamp Figures explorer controls section for better onboarding and usability #2150

Merged
merged 54 commits into from
Sep 9, 2022
Merged

[feat] Revamp Figures explorer controls section for better onboarding and usability #2150

merged 54 commits into from
Sep 9, 2022

Conversation

KaroMourad
Copy link
Contributor

  • Change the controls section layout from vertical to horizontal
  • Add labels to the controls

arsengit and others added 30 commits January 25, 2022 20:20
@arsengit
add show/hide system metric icons
7543d77
@Hamik25
Add circle question icon to icomoon set.
a1576c7
@arsengit
Added run overview icons
0ce5b22
@arsengit
Merge branch 'main' into add-new-icon
ac28dc9 
# Conflicts:
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.eot
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.svg
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.ttf
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.woff
#	aim/web/ui/public/assets/icomoon/icomoonIcons.css
#	aim/web/ui/public/assets/icomoon/selection.json
#	aim/web/ui/src/components/kit/Icon/Icon.d.ts
@arsengit
resolved conflicts with main branch
3738cf2
@arsengit
Merge branch 'main' into add-new-icon
fc515c2
@arsengit
added avatar and branch icons
ce726b4
@arsengit
Merge branch 'main' into add-new-icon
1478ad3
@arsengit
Merge branch 'main' into add-new-icon
807fbe4
@VkoHov
Merge branch 'main' of https://github.com/aimhubio/aim into feature/a…
10b6380 
…dd-new-icon
@VkoHov
Added color scale icons
5c7497a
@VkoHov
Merge branch 'main' of https://github.com/aimhubio/aim into feature/a…
c9cbf61 
…dd-new-icon
@rubenaprikyan
Merge branch 'main' of https://github.com/aimhubio/aim into feature/a…
05cd163 
…dd-new-icon
@rubenaprikyan
Add text icon
c3231ae
@VkoHov
Merge branch 'main' of https://github.com/aimhubio/aim into feature/a…
cbb3232 
…dd-new-icon
@VkoHov
Add minus icon
eda5e3c
@VkoHov
Add minus name to icon types
8c68335
@arsengit
added update time icon
a09277d
@arsengit
Merge branch 'main' into add-new-icon
c380fc7 
# Conflicts:
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.eot
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.svg
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.ttf
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.woff
#	aim/web/ui/public/assets/icomoon/icomoonIcons.css
#	aim/web/ui/public/assets/icomoon/selection.json
#	aim/web/ui/src/components/kit/Icon/Icon.d.ts
@arsengit
Merge branch 'main' into feature/add-new-icon
276fb37
@arsengit
[feat] Add info circle outline icon
ba646f2
@KaroMourad
Merge branch 'main' into feature/add-new-icon
c045766
@KaroMourad
[feat] Add axes-props icon
fd08eb4
@arsengit
Merge branch 'main' into feature/add-new-icon
7ea5cd4
@arsengit
[feat] Add compare icon
4b59b7b
@arsengit
Merge branch 'main' into add-new-icon
b1c3ed0
@arsengit
[feat] Add box-settings, full-screen and new-tab icons
c982d8d
@arsengit
Merge branch 'main' into feature/add-icon
9ea8a7d
@arsengit
[feat] Add figures-explorer icon
bb64103
@arsengit
[feat] Add group-column icon
0d8dfa8
@KaroMourad KaroMourad self-assigned this Sep 6, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KaroMourad
Copy link
Contributor Author

Resolves #2149

@KaroMourad KaroMourad changed the title [feat] Adjust the controls section layout of the figures explorer [feat] Adjust the controls section layout of the Figures explorer Sep 7, 2022
@KaroMourad KaroMourad force-pushed the feature/change-controls-section-layout-in-figures-explorer branch from 667e22e to afa3558 Compare September 7, 2022 13:04
rubenaprikyan
rubenaprikyan suggested changes Sep 9, 2022
View reviewed changes
@KaroMourad KaroMourad requested review from rubenaprikyan and removed request for roubkar and VkoHov September 9, 2022 16:56
rubenaprikyan
rubenaprikyan approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@rubenaprikyan rubenaprikyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@KaroMourad KaroMourad merged commit 0f192e2 into main Sep 9, 2022
@KaroMourad KaroMourad deleted the feature/change-controls-section-layout-in-figures-explorer branch September 9, 2022 17:01
@KaroMourad KaroMourad changed the title [feat] Adjust the controls section layout of the Figures explorer [feat] Revamp Figures explorer controls section for better onboarding and usability Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenaprikyan rubenaprikyan rubenaprikyan approved these changes

Assignees

@KaroMourad KaroMourad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KaroMourad @CLAassistant @rubenaprikyan @arsengit @Hamik25 @VkoHov