Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-health] Separate state slices on explorer engine and improve code quality #2147

Merged
merged 19 commits into from
Sep 28, 2022

Conversation

rubenaprikyan
Copy link
Contributor

@rubenaprikyan rubenaprikyan commented Sep 6, 2022

This PR includes architectural changes on ui core.
Created new explorer-engine which consists of different engines pipeline, instructions, visualizations, custom-states, groupings, query.
Each engine has data access layer (DAL) and business logic layer(BL), called state and engine respectively.
i.e. pipeline s DAL(state) includes data coming from pipeline, current applied groupings, query , pipeline step, status etc. and corresponding selectors. And BL includes group and search methods to search and group from UI.
The rest of engines has the same structure.
This architectural changes are made to create the ui core maintainable, reusable and keep single responsibility for each BL.
This will help to write robust unit and integration tests, It is easy to create new "BaseExplorer" on top of the explorer-engine.

Remarkable changes

  • Integrated redux devtool for zustand store
  • Added a way to inject individual visualizations with box and controls
  • Changed the public api of BaseExplorer configuration
  • Defined default components, configurations for BaseExplorer
    The user may
    • Create its own config
    • Use default hydrations
    • Pass only required configurations

@rubenaprikyan rubenaprikyan self-assigned this Sep 6, 2022
@rubenaprikyan rubenaprikyan changed the base branch from release/3.13.x to main September 14, 2022 14:26
@rubenaprikyan rubenaprikyan changed the title [code health] Separate state slices on explorer engine and improve code quality [code-health] Separate state slices on explorer engine and improve code quality Sep 21, 2022
@rubenaprikyan
Copy link
Contributor Author

Resolves #2146

@rubenaprikyan rubenaprikyan marked this pull request as ready for review September 21, 2022 17:55
@rubenaprikyan rubenaprikyan removed the request for review from VkoHov September 23, 2022 10:48
Copy link
Contributor

@KaroMourad KaroMourad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@rubenaprikyan rubenaprikyan merged commit 751147c into main Sep 28, 2022
@rubenaprikyan rubenaprikyan deleted the code-health/separate-state-chunks-in-ui-core branch September 28, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants