-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-health] Separate state slices on explorer engine and improve code quality #2147
Merged
rubenaprikyan
merged 19 commits into
main
from
code-health/separate-state-chunks-in-ui-core
Sep 28, 2022
Merged
[code-health] Separate state slices on explorer engine and improve code quality #2147
rubenaprikyan
merged 19 commits into
main
from
code-health/separate-state-chunks-in-ui-core
Sep 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #2146 |
…er is not ready yet
…ualizer is not ready yet, by js as well
KaroMourad
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
…//github.com/aimhubio/aim into code-health/separate-state-chunks-in-ui-core
roubkar
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes architectural changes on ui core.
Created new
explorer-engine
which consists of different enginespipeline
,instructions
,visualizations
,custom-states
,groupings
,query
.Each engine has data access layer (DAL) and business logic layer(BL), called state and
engine
respectively.i.e.
pipeline
sDAL
(state) includes data coming from pipeline, current applied groupings, query , pipeline step, status etc. and corresponding selectors. AndBL
includesgroup
andsearch
methods to search and group from UI.The rest of engines has the same structure.
This architectural changes are made to create the ui core maintainable, reusable and keep single responsibility for each BL.
This will help to write robust unit and integration tests, It is easy to create new "BaseExplorer" on top of the
explorer-engine
.Remarkable changes
BaseExplorer
configurationBaseExplorer
The user may