Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Change grouping section layout in figures explorer #2143

Merged

Conversation

VkoHov
Copy link
Contributor

@VkoHov VkoHov commented Sep 4, 2022

  • Move the grouping section under the query form section.
  • Tune the query form section.
  • Tune the grouping section
  • Set the text button instead of the previous element.
  • Try to mix our prev. styles to avoid inconsistency with the query form and app bar.

arsengit and others added 30 commits January 25, 2022 20:20
# Conflicts:
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.eot
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.svg
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.ttf
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.woff
#	aim/web/ui/public/assets/icomoon/icomoonIcons.css
#	aim/web/ui/public/assets/icomoon/selection.json
#	aim/web/ui/src/components/kit/Icon/Icon.d.ts
# Conflicts:
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.eot
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.svg
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.ttf
#	aim/web/ui/public/assets/icomoon/fonts/icomoon.woff
#	aim/web/ui/public/assets/icomoon/icomoonIcons.css
#	aim/web/ui/public/assets/icomoon/selection.json
#	aim/web/ui/src/components/kit/Icon/Icon.d.ts
@VkoHov VkoHov self-assigned this Sep 4, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@VkoHov VkoHov marked this pull request as draft September 4, 2022 16:46
@VkoHov
Copy link
Contributor Author

VkoHov commented Sep 5, 2022

Resolves #2144

@VkoHov VkoHov marked this pull request as ready for review September 6, 2022 12:44
@VkoHov VkoHov requested review from KaroMourad and roubkar and removed request for rubenaprikyan and arsengit September 6, 2022 12:44
Copy link
Contributor

@KaroMourad KaroMourad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VkoHov VkoHov requested a review from KaroMourad September 6, 2022 15:41
@VkoHov VkoHov merged commit 6227108 into main Sep 7, 2022
@VkoHov VkoHov deleted the feature/change-grouping-section-layout-in-figures-explorer branch September 7, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants