Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Change method used for setting Run finalization time #2119

Merged
merged 2 commits into from
Aug 29, 2022
Merged

[fix] Change method used for setting Run finalization time #2119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
214ab4a
[fix] Change finalize() to set_finalization_time() when aim reindex i…
alberttorosyan Aug 29, 2022
75e336f
[doc] Update CHANGELOG.md
alberttorosyan Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 3.13.1

- Fix aim reindex command failure (alberttorosyan)

## 3.13.0 Aug 21, 2022

### Enhancements:
Expand Down
4 changes: 2 additions & 2 deletions aim/sdk/index_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def reindex(self):
stalled_runs = list(self._unindexed_runs())
in_progress_runs = list(self._in_progress_runs())
for run_hash in tqdm.tqdm(stalled_runs, desc='Finalizing stalled runs', total=len(stalled_runs)):
self._run(run_hash).finalize()
self._run(run_hash).set_finalization_time()

# run second pass on newly runs which are killed after reindex started
click.echo('Checking recent runs...')
Expand All @@ -76,7 +76,7 @@ def reindex(self):
if len(new_stalled_runs) > 0:
click.echo('Found new stalled runs.')
for run_hash in tqdm.tqdm(new_stalled_runs, desc='Finalizing stalled runs', total=len(new_stalled_runs)):
self._run(run_hash).finalize()
self._run(run_hash).set_finalization_time()
else:
click.echo('No new stalled runs found.')

Expand Down