Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecation] Warn about deprecation when custom Run.hash is set #2118

Merged

Conversation

alberttorosyan
Copy link
Member

No description provided.

Copy link
Contributor

@mihran113 mihran113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alberttorosyan alberttorosyan merged commit 1cbcd3c into release/3.13.x Sep 1, 2022
@alberttorosyan alberttorosyan deleted the feature/allow-custom-run-hashes-as-deprecated branch September 1, 2022 07:21
@YodaEmbedding
Copy link
Contributor

YodaEmbedding commented Sep 2, 2022

Is there still a way load an existing run (by hash?) in order to query or log to it?

@alberttorosyan
Copy link
Member Author

Is there still a way load an existing run (by hash?) in order to query or log to it?

Absolutely. Existing runs are not affected, even when the deprecated interface is removed. The change is related to only newly created runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants