Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add the ability to edit tags on the Run Page #2104

Merged
merged 3 commits into from
Aug 25, 2022
Merged

[feat] Add the ability to edit tags on the Run Page #2104

merged 3 commits into from
Aug 25, 2022

Conversation

roubkar
Copy link
Contributor

@roubkar roubkar commented Aug 24, 2022

  • Add the ability to edit tags from the Run Page overview sidebar
  • Apply optimistic updates on tags edit functionality
  • Tune styles for the edit button in component

@roubkar roubkar requested a review from arsengit August 24, 2022 14:12
@roubkar
Copy link
Contributor Author

roubkar commented Aug 24, 2022

Resolves #2053

@roubkar roubkar requested review from VkoHov and removed request for arsengit August 25, 2022 11:16
VkoHov
VkoHov approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@VkoHov VkoHov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@roubkar roubkar merged commit de7ea19 into main Aug 25, 2022
@roubkar roubkar deleted the feature/edit-tags-in-run branch August 25, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VkoHov VkoHov VkoHov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roubkar @VkoHov