do not install tests/ and util/ packages #4206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous generic "find_packages()" call in setup.py would also catch the tests/ and utils/ subfolders, installing them into the user's python environment. This not only affected installs from github, but also source releases on PyPI.
|
@sphuber This should go into the 1.3.0 release - let me know whether this means I should make the PR against a different branch |
|
This is something to keep track of for a next plugin developer meeting - I believe many plugins (certainly earlier ones templated via the cookiecutter) are making this mistake. |
|
Heh, see #4204. AFAICT the change is exactly the same, so doesn't matter which one we merge. |
|
Note that this is a problem only if the other packages contain an |
|
hehe ;-) Sorry - I just checked on the issue tracker, not in the PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous generic "find_packages()" call in setup.py would also
catch the tests/ and utils/ subfolders, installing them into the user's
python environment. This not only affected installs from github, but
also source releases on PyPI.