Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to trigger the update of the results tabs. #868

Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Oct 21, 2024

In PR #844 , the process monitor updates the result tabs in another thread. This leads to an issue: when the user interacts with the result, the widget runs in the thread differently from the one running in the process monitor.

Therefore, triggering the automatic updating of the result tabs is not possible.

In this PR, we don't use process monitor anymore. Instead, we add a button to let the user trigger the update manually.

Screenshot from 2024-10-21 13-04-52

I also modified the layout of the buttons (kill, clean) to make the UI pretty.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.09%. Comparing base (c4a453b) to head (69b397b).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/result/__init__.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
- Coverage   67.10%   67.09%   -0.02%     
==========================================
  Files          51       51              
  Lines        4688     4692       +4     
==========================================
+ Hits         3146     3148       +2     
- Misses       1542     1544       +2     
Flag Coverage Δ
python-3.11 67.09% <71.42%> (-0.02%) ⬇️
python-3.9 67.12% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @superstar54 , thanks for this and for improving the other buttons.

Just thinking if we can somehow avoid to render again the tabs if they are already there, but I also think that this will be not a problem when the lazy loading will be there.

So, LGTM!

@superstar54
Copy link
Member Author

Just thinking if we can somehow avoid to render again the tabs if they are already there, but I also think that this will be not a problem when the lazy loading will be there.

Indeed, this is the problem from the node tree. There is a PR to fix it: #560. Will reopen it soon.

@superstar54 superstar54 merged commit 0cf9fad into aiidalab:main Oct 21, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/865/tirgger_update_result_manually branch October 21, 2024 14:31
edan-bainglass added a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants