Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/638/remove job selection #849

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Oct 8, 2024

This PR fixs #813 .

  • Removed the workchain selector on the top
  • Remove the previous, next and reset header.

Then, I added

  • A new Job list button on the top
  • A button to create a new calculation. It will create a new QE App page, instead of reset the current APP.
qeapp-new-joblist.mp4

Closes #814

@superstar54 superstar54 marked this pull request as draft October 8, 2024 13:32
@superstar54 superstar54 linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (ad72633) to head (c4401c9).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/utils/search_jobs.py 22.22% 7 Missing ⚠️
src/aiidalab_qe/app/wrapper.py 62.50% 6 Missing ⚠️
src/aiidalab_qe/app/main.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   68.35%   67.72%   -0.64%     
==========================================
  Files          50       50              
  Lines        4573     4598      +25     
==========================================
- Hits         3126     3114      -12     
- Misses       1447     1484      +37     
Flag Coverage Δ
python-3.11 67.72% <60.00%> (-0.64%) ⬇️
python-3.9 67.75% <60.00%> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add a button to start a new calculation, by open a new qe app page.
@superstar54 superstar54 force-pushed the fix/638/remove_job_selection branch from 59f30f8 to 6ddc971 Compare October 8, 2024 14:59
@superstar54 superstar54 marked this pull request as ready for review October 8, 2024 15:02
layout=ipw.Layout(width="auto")
# Add a button to start a new calculation
self.new_work_chains_button = ipw.Button(
description="New calculation",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start New Calculation
Might be more explicit for the user

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I changed it to Start New Calculation.

@AndresOrtegaGuerrero
Copy link
Member

I think the button named "Job list" it might not be intuitive to the users, Maybe we should re label to something more explicit?
"Previous Calculations" or "View Previous Runs" or "Job History" , so we dont need some text to guide the user where to find the calculations

@AndresOrtegaGuerrero
Copy link
Member

I think the same apply to the button Guide , maybe we should use

"How to Use" or "Usage Guide" or even "Getting Started" , and maybe we can change the icon to icon="fa-book",

@superstar54
Copy link
Member Author

I think the button named "Job list" it might not be intuitive to the users, Maybe we should re label to something more explicit?

Thanks for the suggestion. I changed the Job list to Job History.

"How to Use" or "Usage Guide" or even "Getting Started" , and maybe we can change the icon to icon="fa-book",

For the Guide button, I will let @edan-bainglass decide and make changes if needed.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you Xing

@edan-bainglass
Copy link
Member

I think the same apply to the button Guide , maybe we should use\n\n"How to Use" or "Usage Guide" or even "Getting Started" , and maybe we can change the icon to icon="fa-book",

I like Getting Started, and the book icon might be a nice touch. Maybe check what others do along Getting Started.

@superstar54 superstar54 merged commit a772142 into aiidalab:main Oct 9, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/638/remove_job_selection branch October 9, 2024 10:02
@AndresOrtegaGuerrero
Copy link
Member

I think the same apply to the button Guide , maybe we should use\n\n"How to Use" or "Usage Guide" or even "Getting Started" , and maybe we can change the icon to icon="fa-book",

I like Getting Started, and the book icon might be a nice touch. Maybe check what others do along Getting Started.

Should we open an issue to replace it ? @superstar54

edan-bainglass added a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants