-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/638/remove job selection #849
Fix/638/remove job selection #849
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 68.35% 67.72% -0.64%
==========================================
Files 50 50
Lines 4573 4598 +25
==========================================
- Hits 3126 3114 -12
- Misses 1447 1484 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add a button to start a new calculation, by open a new qe app page.
59f30f8
to
6ddc971
Compare
src/aiidalab_qe/app/main.py
Outdated
layout=ipw.Layout(width="auto") | ||
# Add a button to start a new calculation | ||
self.new_work_chains_button = ipw.Button( | ||
description="New calculation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start New Calculation
Might be more explicit for the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I changed it to Start New Calculation
.
I think the button named "Job list" it might not be intuitive to the users, Maybe we should re label to something more explicit? |
I think the same apply to the button Guide , maybe we should use "How to Use" or "Usage Guide" or even "Getting Started" , and maybe we can change the icon to |
Thanks for the suggestion. I changed the
For the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you Xing
I like Getting Started, and the book icon might be a nice touch. Maybe check what others do along Getting Started. |
Should we open an issue to replace it ? @superstar54 |
This PR fixs #813 .
previous
,next
andreset
header.Then, I added
Job list
button on the topqeapp-new-joblist.mp4
Closes #814