Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility issue #847

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mikibonacci
Copy link
Member

This fixes #845

Hi @AndresOrtegaGuerrero , @superstar54 , could you please try again, to see if the PR solves your issue? thanks a lot

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.07%. Comparing base (4c19d24) to head (e04e438).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/result/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #847   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files          50       50           
  Lines        4561     4561           
=======================================
  Hits         3105     3105           
  Misses       1456     1456           
Flag Coverage Δ
python-3.11 68.07% <0.00%> (ø)
python-3.9 68.10% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! , thanks!

@superstar54 superstar54 merged commit 14e5009 into aiidalab:main Oct 8, 2024
8 checks passed
@mikibonacci mikibonacci deleted the fix/backward-compatibility branch October 8, 2024 08:45
edan-bainglass added a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backward compatibility of the clean_button and exception catching
3 participants