-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HubbardStructureData reach by StructureBrowserWidget #718
Merged
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
424d822
HubbardStructureData reach by StructureBrowserWidget
AndresOrtegaGuerrero 13835eb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1d657e4
modification of qe_app wc
AndresOrtegaGuerrero ede7fdd
Merge branch 'mod/structure_browser_widget' of https://github.com/aii…
AndresOrtegaGuerrero d202567
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 95f8731
set U values from HubbardStructure data
AndresOrtegaGuerrero ccbf3f3
Merge branch 'mod/structure_browser_widget' of https://github.com/aii…
AndresOrtegaGuerrero ce5b74c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 154c95b
if hubbard parameters are the same, keep the same structure
AndresOrtegaGuerrero c0108b0
use func name as set_parameters_from_hubbardstructure
AndresOrtegaGuerrero 28be809
allowing override to set the U values for HubbardStructureData
AndresOrtegaGuerrero 0fd4c7e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4623da7
modification of logic
AndresOrtegaGuerrero 242a02d
Merge branch 'mod/structure_browser_widget' of https://github.com/aii…
AndresOrtegaGuerrero 3e1466e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6e85b6b
moving logic up
AndresOrtegaGuerrero e61af72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2894624
simply logic
AndresOrtegaGuerrero 5885b06
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raise error when
structure
is a normal StructureData, which doesn't havehubbard
. I think you don't need check thehubbard
here, because you need to use the newly createdhubbard_structure
.