add reminder text when users selecting property #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 75.47% 75.77% +0.30%
==========================================
Files 60 60
Lines 4404 4327 -77
==========================================
- Hits 3324 3279 -45
+ Misses 1080 1048 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| # observer change to update the reminder text | ||
| def update_reminder_text(change, reminder_text=reminder_text): | ||
| if change["new"]: | ||
| reminder_text.value = """(There is a setting panel available for this property on the top.)""" |
There was a problem hiding this comment.
What about like "Use the set panel for $property on top"
There was a problem hiding this comment.
Thanks for the suggestion. I changed it to
f"""Customize {name} settings in the panel above if needed."""Do you think it's OK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #662
Here is a demo:
qeapp-reminder.mp4