-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docstrings and documentation consistent #649
Conversation
Hi @PNOGillespie, thanks for the valuable feedback. Could you please check this PR and see if it makes the text clearer to the user? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 75.85% 75.85%
=======================================
Files 60 60
Lines 4312 4312
=======================================
Hits 3271 3271
Misses 1041 1041
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @superstar54, this seems reasonable to me. I've suggested a small correction to the first docstring, but overall this does address the point I raised in the Issue page - nice work.
Co-authored-by: Peter Gillespie <55498719+PNOGillespie@users.noreply.github.com>
Thanks @PNOGillespie , I adapted your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me @superstar54, nice work.
fix #496