-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logo #635
Update logo #635
Conversation
ee55e17
to
e6b912e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 80.73% 75.78% -4.95%
==========================================
Files 49 60 +11
Lines 3415 4299 +884
==========================================
+ Hits 2757 3258 +501
- Misses 658 1041 +383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@edan-bainglass thanks for the update. Do you know why the text on the SVG image overlaps? At lease on my browser and computer. |
f435181
to
dc096a7
Compare
Updated the logo to handle light and dark modes. However, the |
@superstar54 can we merge this? |
I really want to merge this. However, I still see strange logo in my computer. @AndresOrtegaGuerrero , could you check the logo in the page If no problem in your computer, we can merge this PR. |
@superstar54 Is the same for me @edan-bainglass Do you know how we can fix this ? |
Probably need to stop using SVG files I suppose. PNG versions shouldn't have this problem. I'll look into it tomorrow. |
1a26013
to
f78f6b4
Compare
f78f6b4
to
e32d592
Compare
Switched to png files. Tested on Windows and Linux. @AndresOrtegaGuerrero let me know how it looks on your Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you Edan
@mbercx is the required amd64 test not running somehow connected to your office machine? Is it down again? 😞 |
Per request, changing logo to "The AiiDAlab Quantum ESPRESSO App"