Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo #635

Merged
merged 1 commit into from
May 6, 2024
Merged

Update logo #635

merged 1 commit into from
May 6, 2024

Conversation

edan-bainglass
Copy link
Member

Per request, changing logo to "The AiiDAlab Quantum ESPRESSO App"

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (f63da7d) to head (dc096a7).
Report is 87 commits behind head on main.

❗ Current head dc096a7 differs from pull request most recent head e32d592. Consider uploading reports for the commit e32d592 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   80.73%   75.78%   -4.95%     
==========================================
  Files          49       60      +11     
  Lines        3415     4299     +884     
==========================================
+ Hits         2757     3258     +501     
- Misses        658     1041     +383     
Flag Coverage Δ
python-3.10 75.78% <ø> (-4.95%) ⬇️
python-3.8 ?
python-3.9 75.81% <ø> (-4.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member

@edan-bainglass thanks for the update. Do you know why the text on the SVG image overlaps? At lease on my browser and computer.

@edan-bainglass edan-bainglass force-pushed the logo-update branch 6 times, most recently from f435181 to dc096a7 Compare March 21, 2024 12:37
@edan-bainglass
Copy link
Member Author

Updated the logo to handle light and dark modes. However, the pydata-sphinx-theme built-in dark-light class does not seem to work when applied to the icon on the front page. It works when I build the docs locally, just not on the remote for some reason.

@edan-bainglass
Copy link
Member Author

@superstar54 can we merge this?

@superstar54
Copy link
Member

@superstar54 can we merge this?

I really want to merge this. However, I still see strange logo in my computer.

Screenshot from 2024-04-30 17-10-01

@AndresOrtegaGuerrero , could you check the logo in the page
https://aiidalab-qe--635.org.readthedocs.build/

If no problem in your computer, we can merge this PR.

@AndresOrtegaGuerrero
Copy link
Member

@superstar54 Is the same for me
image

@edan-bainglass Do you know how we can fix this ?

@edan-bainglass
Copy link
Member Author

Probably need to stop using SVG files I suppose. PNG versions shouldn't have this problem. I'll look into it tomorrow.

@edan-bainglass
Copy link
Member Author

Switched to png files. Tested on Windows and Linux. @AndresOrtegaGuerrero let me know how it looks on your Mac.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Edan

@edan-bainglass
Copy link
Member Author

@mbercx is the required amd64 test not running somehow connected to your office machine? Is it down again? 😞

@superstar54 superstar54 merged commit 84d1599 into aiidalab:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants