Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the load_profile warning by move it to front #599

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 24, 2024

The problem is introduced by #593, where I move the load_profile to after the import of AWB.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f63da7d) 80.73% compared to head (658e826) 80.86%.
Report is 18 commits behind head on main.

Files Patch % Lines
src/aiidalab_qe/common/node_view.py 0.00% 1 Missing ⚠️
src/aiidalab_qe/common/setup_pseudos.py 50.00% 1 Missing ⚠️
src/aiidalab_qe/common/widgets.py 0.00% 1 Missing ⚠️
src/aiidalab_qe/plugins/bands/workchain.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   80.73%   80.86%   +0.13%     
==========================================
  Files          49       49              
  Lines        3415     3429      +14     
==========================================
+ Hits         2757     2773      +16     
+ Misses        658      656       -2     
Flag Coverage Δ
python-3.10 80.86% <90.24%> (+0.13%) ⬆️
python-3.8 80.91% <90.24%> (+0.13%) ⬆️
python-3.9 80.91% <90.24%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested and it removed the warning message, LGTM ! , thank you !

@unkcpz unkcpz merged commit c9d010a into main Jan 24, 2024
17 checks passed
@unkcpz unkcpz deleted the fix/xx/load_profile_warning branch January 24, 2024 19:11
unkcpz added a commit to unkcpz/aiidalab-qe that referenced this pull request Jan 25, 2024
The problem is introduced by aiidalab#593, where I move the load_profile to after the import of AWB.
unkcpz added a commit that referenced this pull request Jan 25, 2024
* Remove the load_profile warning by move it to front (#599)
* removing force_parity from create_kpoints_from_distance (#598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants