Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More text and typo fixes #296

Merged
merged 1 commit into from
Sep 20, 2022
Merged

More text and typo fixes #296

merged 1 commit into from
Sep 20, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Sep 20, 2022

No description provided.

@unkcpz unkcpz requested a review from csadorf September 20, 2022 10:59
@unkcpz unkcpz mentioned this pull request Sep 20, 2022
Copy link
Member

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member Author

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly from my carelessness.

@@ -29,7 +29,7 @@ class WorkChainSelector(ipw.HBox):

def __init__(self, **kwargs):
self.work_chains_prompt = ipw.HTML(
"<b>Select computed workflow or start a new:</b>&nbsp;"
"<b>Select computed workflow or start a new one:</b>&nbsp;"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a close look, and there is one in Nicola's feedback, that overlaps with other text. My fault for not checking it carefully.

@@ -43,7 +43,7 @@ class PseudoFamilySelector(ipw.VBox):
)
dft_functional_help = ipw.HTML(
"""<div style="line-height: 140%; padding-top: 10px; padding-bottom: 10px; opacity:0.5;">
The exchange-correlation energy is calculated functional. We currently provide support for two
The exchange-correlation energy is calculated using this functional. We currently provide support for two
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My careless about this.

@@ -169,7 +169,7 @@ class SmearingSettings(ipw.VBox):
"""<p>
The smearing type and width is set by the chosen <b>protocol</b>.
Tick the box to override the default, not advised unless you've mastered <b>smearing effects</b> (click <a href="http://theossrv1.epfl.ch/Main/ElectronicTemperature"
target="_blank">HERE</a> for a discussion).
target="_blank">here</a> for a discussion).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all capitalized on Nicola's writing, I guess it is not necessary to use 'HERE', lowercase should be fine.

@unkcpz unkcpz merged commit d95ea88 into master Sep 20, 2022
@unkcpz unkcpz deleted the text-update/more branch September 20, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants