Fix downstream CI and add manually triggered downstream CI test #223
Conversation
|
I accidentally push a fix of downstream ci fix (untested) to the master, since as admin we are not limited. The owner permission setting is reset to as owner of the repo we also need to push to unprotected branch first instead of push to master directly. |
0829283 to
a0b2032
Compare
No, It shouldn't, I added it to trigger it manually. I change it back and after this merged, we can go to CI action and trigger the test manually, hopefully? |
| By.XPATH, '//li[@id="tab-key-17" and @class="lm-TabBar-tab p-TabBar-tab"]' | ||
| ).click() # click `From Examples` for input structure | ||
| By.XPATH, '//li[@id="tab-key-17"]' | ||
| ).click() # click `From Examples` tab for input structure |
There was a problem hiding this comment.
This looks like an unrelated change. Do you want to merge it with this PR?
There was a problem hiding this comment.
It is the fix of a previously wrongly pushed commit f2d840d. I test locally this change will pass the downstream CI.
I think we can merge it with this PR and I then specify the details about this commit.
There was a problem hiding this comment.
For next time I would recommend to explicitly revert f2d840d and then apply the additional change. You could still do this here and then either rebase and merge or squash merge.
| By.XPATH, '//li[@id="tab-key-17" and @class="lm-TabBar-tab p-TabBar-tab"]' | ||
| ).click() # click `From Examples` for input structure | ||
| By.XPATH, '//li[@id="tab-key-17"]' | ||
| ).click() # click `From Examples` tab for input structure |
There was a problem hiding this comment.
For next time I would recommend to explicitly revert f2d840d and then apply the additional change. You could still do this here and then either rebase and merge or squash merge.
54db1c1 to
6ff2acd
Compare
No description provided.