Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Leftover reset of input_structure in ConfigureStep #212

Merged
merged 1 commit into from
May 16, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Mar 3, 2022

There is no such attribute input_structure of class ConfigureQeAppWorkChainStep. Although this cause nothing when reset in the configure step (I am surprised this does not raise any exception🧐), anyway should be deleted.

@unkcpz unkcpz requested a review from mbercx March 3, 2022 09:59
@unkcpz unkcpz added this to the 2022.06 milestone May 6, 2022
@unkcpz unkcpz requested a review from csadorf May 15, 2022 11:46
Copy link
Member

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you surprised that this didn't cause an exception?

@unkcpz
Copy link
Member Author

unkcpz commented May 16, 2022

Why are you surprised that this didn't cause an exception?

Well, not a surprise anymore. Just intuitively confused seems found no this attribute in the class. This is python 😆, an assignment expression without declaration totally what it is.

@unkcpz unkcpz merged commit d07cc0f into master May 16, 2022
@unkcpz unkcpz deleted the fix/conf-reset branch May 16, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants