Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Reporting when only PDOS is calculated #207

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Feb 22, 2022

Fixes #204

Fix two issues when calculating only the PDOS:

  • Show the correct energy cutoffs and k-points distance for the SCF.
  • Properly show the "Electronic Structure" output, which currently isn't
    shown because the _update_view method only checks for the
    band_structure output.

Fix two issues when calculating only the PDOS:

* Show the correct energy cutoffs and k-points distance for the SCF.
* Properly show the "Electronic Structure" output, which currently isn't
shown because the `_update_view` method only checks for the
`band_structure` output.
@mbercx mbercx requested a review from unkcpz February 22, 2022 11:16
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbercx Thanks! Look all good.

Also test with running some test with only pdos, no issues found.

@unkcpz unkcpz merged commit 498aee7 into aiidalab:master Feb 25, 2022
@mbercx mbercx deleted the fix/204/pdos-only branch February 25, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only calculating the PDOS shows incorrect settings
2 participants