Shuffle results panel top-level tabs and update default selection #1076
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
+ Coverage 68.98% 69.11% +0.13%
==========================================
Files 113 113
Lines 6764 6764
==========================================
+ Hits 4666 4675 +9
+ Misses 2098 2089 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
959c98a to
709dcd0
Compare
| self.toggle_controls.value = "Summary" | ||
| self.toggle_controls.value = ( | ||
| "Results" | ||
| if (process := self._model.fetch_process_node()) and process.is_finished_ok |
There was a problem hiding this comment.
If a process has multiple properties and one fails, would this prevent the visualization of the results for the properties that completed successfully?
There was a problem hiding this comment.
I don't see why it would. This is just defining the default selected tab. All three tabs are still there.
There was a problem hiding this comment.
because if one fail, process.is_finished_ok will be false , right ?
There was a problem hiding this comment.
The default in this case is Status and the app will direct the user there. But the other panels are still accessible.
This PR does the following: