-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DependentStep
mixin with proper QeWizardStep
MVC classes
#1032
Replace DependentStep
mixin with proper QeWizardStep
MVC classes
#1032
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
==========================================
+ Coverage 69.04% 69.05% +0.01%
==========================================
Files 117 117
Lines 6507 6506 -1
==========================================
Hits 4493 4493
+ Misses 2014 2013 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
09add67
to
349c0df
Compare
349c0df
to
30bf188
Compare
This PR resolves issues with #1004 (incorrect handling of step-to-step switching/rendering) by treating the app steps more uniformly. It also introduces a simple locking mechanism on submission that disconnects all observations of step confirmation, thus rendering the app in a "locked" state by permanently disabling confirm/submit buttons.
@superstar54 note that this also simplifies the handling of "invalid" dependent steps (referencing your comment on #1004)