Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up recent developments in the app wrapper classes to better fit with the overall MVC design of the app.
Modifications
enable_toggles()
toenable_controls()
, as the top-level controls are no longer only toggle buttonsAppWrapperModel
state variables and syncAppWrapperController
AppWrapperController._open_external_notebook
as a generic means of handling such eventsNote regarding
_open_external_notebook
#1011 actually discards this method in favor of anchor tags to avoid pop-up blocking.