Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve calculation history page #1002

Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Dec 18, 2024

Fix #1001

Improve the calculation history page

  • PK: Possibility to toggle between PK/uuid(initial part) [low prio]
  • pk/uuid is a link replacing "inspect" [low prio]
  • Creation time: Possibility to toggle between 2024-11-21 18:54 and 223D ago [low prio]
  • Label: Make job list editable (for label and description) [middle priority, but can be done in a different place, even in the main QE app notebook]
  • Job state dropdown -> excepted instead of except? And default not empty but "Any"
  • Job state column -> use more understandable words (e.g. running instead of waiting) and (for the future) think if the sentence can say more about the progress, e.g. Running (2/6)
  • Search label Extend search to Description and mention it
  • Checkbox to additionally show the description (row below?) or maybe just tooltip
  • properties filter: explain what it means to add the checkbox: now no checkbox has a special meaning? Should all be selected by default, and having a checkbox means only include calculations with that property?
  • add a sentence after the title, about what this Job History is
  • add download button(s: two types, .aiida and dump) in job list
  • Deletion should ask for confirmation
  • have option in the job list to "hide" them (with filter to show also hidden, so you can "unhide" them)
  • should we make the table slightly more colorful to give more info? (And rename some columns e.g. with emoji for the state, show also initial part of UUID, ...)

Note: There are two tasks left: which can not be implemented using the current HTML format. We need to find a solution to allow the users to interact with the table, e.g., create a table widget using any widget. This could also solve other missing features: pagination and page size.

Screenshot from 2024-12-19 12-55-20
Screenshot from 2024-12-19 12-55-12

@superstar54 superstar54 changed the title Improve calculation history page [WIP] Improve calculation history page Dec 18, 2024
@superstar54 superstar54 marked this pull request as draft December 18, 2024 10:37
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 68.14%. Comparing base (b288780) to head (dc4790a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/utils/search_jobs.py 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
- Coverage   68.40%   68.14%   -0.26%     
==========================================
  Files         111      111              
  Lines        6293     6317      +24     
==========================================
  Hits         4305     4305              
- Misses       1988     2012      +24     
Flag Coverage Δ
python-3.11 68.14% <0.00%> (-0.25%) ⬇️
python-3.9 68.17% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 force-pushed the fix/1001/improve_calculation_history branch from adc1006 to 67aacc8 Compare December 19, 2024 09:28
@superstar54 superstar54 force-pushed the fix/1001/improve_calculation_history branch from 67aacc8 to b89cbde Compare December 19, 2024 09:29
@superstar54 superstar54 changed the title [WIP] Improve calculation history page Improve calculation history page Dec 19, 2024
@superstar54 superstar54 marked this pull request as ready for review December 19, 2024 11:58
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic @superstar54 🎉 LGTM! Let's discuss soon regarding a more generic table widget.

@superstar54 superstar54 merged commit 5f57e25 into aiidalab:main Dec 20, 2024
7 of 8 checks passed
@superstar54 superstar54 deleted the fix/1001/improve_calculation_history branch December 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants