Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set nbnd for pdos workchain #1000

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Dec 18, 2024

fix #999

In #965, nbands_factor is used in PdosWorkChain, thus we should not set nbnd anymore.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.59%. Comparing base (9522470) to head (3063cf5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
+ Coverage   68.55%   68.59%   +0.03%     
==========================================
  Files         111      111              
  Lines        6307     6304       -3     
==========================================
  Hits         4324     4324              
+ Misses       1983     1980       -3     
Flag Coverage Δ
python-3.11 68.57% <ø> (+0.01%) ⬆️
python-3.9 68.61% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass
Copy link
Member

Thanks @superstar54. I mentioned to @AndresOrtegaGuerrero regarding encountering #999. I'm tagging him here to let him know this has been handled.

Copy link
Member

@mikibonacci mikibonacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @superstar54 , thanks a lot, LGTM!

@superstar54 superstar54 merged commit 85ceafc into aiidalab:main Dec 18, 2024
7 of 8 checks passed
@superstar54 superstar54 deleted the fix/999/nbands_factor branch December 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants