Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit button doesn't get immediately disabled and it might take 2-3 seconds to go to next step #994

Closed
edan-bainglass opened this issue Dec 17, 2024 · 1 comment · Fixed by #978
Closed

Submit button doesn't get immediately disabled and it might take 2-3 seconds to go to next step #994

edan-bainglass opened this issue Dec 17, 2024 · 1 comment · Fixed by #978
Assignees
@edan-bainglass

Comments

@edan-bainglass
Copy link
Member

Users might then click multiple times. Disable it as the very first thing
@edan-bainglass edan-bainglass self-assigned this Dec 17, 2024
@edan-bainglass
Copy link
Member Author

Resolved in #978

@edan-bainglass edan-bainglass mentioned this issue Dec 18, 2024
Merged
edan-bainglass added a commit that referenced this issue Dec 19, 2024
@edan-bainglass
Redesign status and results step (#978)
aad3410 
This PR redesigns step 4 as follows:

- Split step into three "tabs":
  - Parameters summary and data download controls
  - Result panels
  - Process status views
    - "simplified" view (to be implemented in a later PR), and
    - "advanced" view (the current process tree)
- Smoothly handle transition from submission to results - the app now proceeds to step 4 while the builder is created and submitted. Step 4 is updated once the process is ready (Submit button doesn't get immediately disabled and it might take 2-3 seconds to go to next step #994)
  - Also resolves the issue where the submit button can be repeatedly pressed
- Discard redundant "Update results" button
- Disable raw-data/archive download buttons when downloading (Disable download button when clicked, until the download starts #977)
- Inject process pk to url on submission (Change URL when calc is submitted (and PK is assigned) #990)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edan-bainglass edan-bainglass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redesign status and results step edan-bainglass/aiidalab-qe
1 participant
@edan-bainglass