-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Downstream-integration tests are failing #205
Comments
Thanks @csadorf. I disable the action and will try to figure out how to fix it. I think what we are going to fix is the action https://github.com/aiidalab/aiidalab-test-app-action, correct? |
Yes, we probably need to revise the action. Without any additional test scripts, it primarily acts as a smoke test, where it tries to open the app in the browser and checks that it loaded without any issues. This will catch 80% of critical failure cases related to dependency incompatibilities and so on. |
The goal is to be able to run Proposed approach for implementing tests:
---
# tests/docker-compose.yml
version: '3.4'
services:
aiidalab:
image: aiidalab/full-stack:edge
ports:
- 8888
volumes:
- ${PWD}:/home/jovyan/workspace
env:
AIIDALAB_DEFAULT_APPS: quantum-espresso@file:///home/jovyan/workspace |
This will be fixed by #271 where I implement the basic test along the way suggested. |
It is now migrating to AiiDA 2.x with also its new features supported such as `InstalledCode`. The CI downstream test is added. This will fix issue #205. To conform with the thread-local/traitlets issue, we change also all traitlets related to threads in the code base. We are now getting rid of all the widgets using AiiDA node as traitlets except `NodeViewWidget` and `MinimalStructureViewer`, which will be further tested.
The scheduled downstream-integration workflow is currently failing.
@unkcpz I would recommend to fix it and disable the workflow until then.
The text was updated successfully, but these errors were encountered: