Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Downstream-integration tests are failing #205

Closed
csadorf opened this issue Feb 22, 2022 · 5 comments
Closed

CI: Downstream-integration tests are failing #205

csadorf opened this issue Feb 22, 2022 · 5 comments
Assignees

Comments

@csadorf
Copy link
Member

csadorf commented Feb 22, 2022

The scheduled downstream-integration workflow is currently failing.

@unkcpz I would recommend to fix it and disable the workflow until then.

@unkcpz
Copy link
Member

unkcpz commented Feb 22, 2022

Thanks @csadorf. I disable the action and will try to figure out how to fix it.

I think what we are going to fix is the action https://github.com/aiidalab/aiidalab-test-app-action, correct?

@csadorf
Copy link
Member Author

csadorf commented Feb 22, 2022

Yes, we probably need to revise the action. Without any additional test scripts, it primarily acts as a smoke test, where it tries to open the app in the browser and checks that it loaded without any issues. This will catch 80% of critical failure cases related to dependency incompatibilities and so on.

@unkcpz
Copy link
Member

unkcpz commented Apr 11, 2022

Mmore subtle issue about downstream CI test. The qe-app can't be loaded by using the [aiidalab-test-app-action](https://github.com/aiidalab/aiidalab-test-app-action).

image

@csadorf
Copy link
Member Author

csadorf commented Sep 22, 2022

The goal is to be able to run pytest inside the repository root, and it will automatically run all tests.

Proposed approach for implementing tests:

  1. Copy the approach for setting up a test environment from the aiidalab-docker-stack test config with pytest-docker (test against docker.io/aiidalab/full-stack:edge).
  2. Install the tested app by mounting the repository (/the GitHub workspace directory) and adding it to the AIIDALAB_DEFAULT_APPS environment variable (see example below).
  3. Implement basic smoke tests (is app directory present, is app reported installed by aiidalab etc.)
  4. Implement interface tests with selenium, you can get the url from the notebook_service fixture.
---
# tests/docker-compose.yml
version: '3.4'
services:
    aiidalab:
        image: aiidalab/full-stack:edge
        ports:
            - 8888
        volumes:
            - ${PWD}:/home/jovyan/workspace
        env:
            AIIDALAB_DEFAULT_APPS: quantum-espresso@file:///home/jovyan/workspace

@csadorf csadorf assigned dou-du and unassigned csadorf and unkcpz Sep 22, 2022
@unkcpz unkcpz assigned unkcpz and unassigned dou-du Nov 8, 2022
@unkcpz
Copy link
Member

unkcpz commented Nov 15, 2022

This will be fixed by #271 where I implement the basic test along the way suggested.

unkcpz added a commit that referenced this issue Nov 22, 2022
It is now migrating to AiiDA 2.x with also its new features supported such as `InstalledCode`.
The CI downstream test is added. This will fix issue #205. 
To conform with the thread-local/traitlets issue, we change also all traitlets related to threads in the code base. 
We are now getting rid of all the widgets using AiiDA node as traitlets except `NodeViewWidget` and `MinimalStructureViewer`, which will be further tested.
@unkcpz unkcpz closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants