Skip to content

Commit

Permalink
fix(pypi): correctly pass extra_pip_args when building sdists
Browse files Browse the repository at this point in the history
Before this change the `extra_pip_args` would not be passed down the
chain if `experimental_index_url` is set. This adds a test and fixes the
bug.

Work towards bazelbuild#260.
  • Loading branch information
aignas committed Nov 2, 2024
1 parent b6fc2a0 commit 7f14843
Show file tree
Hide file tree
Showing 4 changed files with 464 additions and 18 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ A brief description of the categories of changes:
`bzlmod` users would have observed.
* (pypi) (Bazel 7.4+) Allow spaces in filenames included in `whl_library`s
([617](https://github.com/bazelbuild/rules_python/issues/617)).
* (pypi) When {attr}`pip.parse.experimental_index_url` is set, we need to still
pass the `extra_pip_args` value when building an `sdist`.

{#v0-0-0-added}
### Added
Expand Down
Loading

0 comments on commit 7f14843

Please sign in to comment.