Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move up to C++20 #220

Merged
merged 3 commits into from
Jan 20, 2025
Merged

feat: move up to C++20 #220

merged 3 commits into from
Jan 20, 2025

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Jan 20, 2025

Description

This PR updates control libraries to c++20

Review guidelines

Estimated Time of Review: 2 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 requested a review from bpapaspyros January 20, 2025 09:38
@bpapaspyros
Copy link
Member

I think we also have some c++-specific mentions in the clproto generation (setup.py perhaps?) not sure we need to upgrade there, but we should at least verify

Copy link
Member

@bpapaspyros bpapaspyros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@domire8 domire8 merged commit c2ae623 into breaking Jan 20, 2025
5 checks passed
@domire8 domire8 deleted the feat/cpp20 branch January 20, 2025 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants